fix(make): make release target portable and consistently signed#24
Merged
Conversation
The `release:` target used BSD-style `sed -i ''` for in-place edits, which fails on GNU sed (where `-i` takes an optional suffix and `''` gets consumed as that suffix, leaving the expression treated as a filename). Switched both substitutions to `perl -i -pe`, which behaves identically on macOS and Linux with no temp file. The version-bump commit was also being created without `--signoff` or `--gpg-sign`, even though the matching tag is signed. Aligned the commit invocation with the project's signing convention. Signed-off-by: Andre Nogueira <aanogueira@protonmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
release:target switched from BSD-stylesed -i ''toperl -i -pefor the two version-bump substitutions. The old form fails on GNU sed (Linux, or macOS with Nix/coreutils in PATH) because GNU-itreats''as an optional suffix and then tries to read the expression as a filename.--signoff --gpg-sign, matching the already-signedgit tag -son the next line and the project's commit convention.Test plan
perl -i -pe 's/^version = ".*"/version = "1.2.0"/'against a copy ofCargo.tomlproduces the expected rewritemake release VERSION=<next>end-to-end on the next real release🤖 Generated with Claude Code